Wireshark-commits: [Wireshark-commits] master ea763a9: Qt: select a better default Decode As table
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 May 2018 08:19:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea763a96387d9f56d5325d5dcd96048666636aab
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea763a9 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: select a better default Decode As table
    
    USB has three possible tables, usb.device, usb.product and usb.protocol
    (shown in that order in the Decode As dialog). For single packets with
    no prior device descriptors, the last two tables have no valid selector
    (integer zero). In such cases it seems more reasonable to use tables for
    which a valid selector exists (for example, "usb.device").
    
    Bug: 14717
    Change-Id: I2319817fa11318a97519d8cfc912343b16224c12
    Reviewed-on: https://code.wireshark.org/review/27820
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2ef7e8c   SCTPAllAssocsDialog: fix memleak of "sctp_assocs"
    adds  ea763a9   Qt: select a better default Decode As table


Summary of changes:
 ui/qt/models/decode_as_model.cpp | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)