Wireshark-commits: [Wireshark-commits] master-2.6 083e569: Fix incorrect formatting of NSAP area ad
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 May 2018 18:57:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=083e569105d9043d39144ad7ca055b7717266dc9
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

083e569 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix incorrect formatting of NSAP area addresses/address prefixes.
    
    If the area address/address prefix is 13 octets long, use the 13th
    octet, not the 21st octet; the latter is *not* part of the area
    address/address prefix, and might either not be in the packet or might
    be some random other part of the packet.
    
    Add/expand comments while we're at it.
    
    Bug: 14744
    Change-Id: I7b90318a72a49b67d8ec17952add528185fd064b
    Reviewed-on: https://code.wireshark.org/review/27848
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 101b692569f17d14f7165446a8a2ae26415057cb)
    Reviewed-on: https://code.wireshark.org/review/27849
    

Actions performed:

    from  13d58c8   6LoRH: fix in IP-in-IP header dissector
    adds  083e569   Fix incorrect formatting of NSAP area addresses/address prefixes.


Summary of changes:
 epan/osi-utils.c | 30 ++++++++++++++++++++++++++++--
 epan/osi-utils.h |  2 +-
 2 files changed, 29 insertions(+), 3 deletions(-)