Wireshark-commits: [Wireshark-commits] master 63f7668: ssh: change return value from gint to guint
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 May 2018 05:52:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63f766899059655b859d063b66dd3e533a50b67b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

63f7668 by Dario Lombardo (lomato@xxxxxxxxx):

    ssh: change return value from gint to guint (CID: 1417453).
    
    Since we're returning the key_len, there is no point in returning
    a signed int.
    
    Change-Id: I8854868ecf5250dca1894fdb8910d9ed48c070db
    Reviewed-on: https://code.wireshark.org/review/27781
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7f4c2ba   ciscodump: check return value of libpcap_write_packet (CID: 1435606).
    adds  63f7668   ssh: change return value from gint to guint (CID: 1417453).


Summary of changes:
 epan/dissectors/packet-ssh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)