Wireshark-commits: [Wireshark-commits] master ca1999f: ua3g: move if in the fallthrough case.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 May 2018 12:48:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca1999f2d270de3b07acd35f4a2e113731d0743c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ca1999f by Dario Lombardo (lomato@xxxxxxxxx):

    ua3g: move if in the fallthrough case.
    
    From gcc version 7 this causes an error:
    
    ../epan/dissectors/packet-ua3g.c:1293:28: error: this statement may fall through [-Werror=implicit-fallthrough=]
                             if (parameter_id == 0x02)
                                ^
    ../epan/dissectors/packet-ua3g.c:1295:21: note: here
                         case 0x03: /* Type Of Service */
                         ^~~~
    cc1: all warnings being treated as errors
    
    Fixes: 31663c40
    Change-Id: I7622614e5472cc70aac5690d4bfc327be7628ece
    Reviewed-on: https://code.wireshark.org/review/27800
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  53dfec9   Qt: Configure the selection color via the preferences
    adds  ca1999f   ua3g: move if in the fallthrough case.


Summary of changes:
 epan/dissectors/packet-ua3g.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)