Wireshark-commits: [Wireshark-commits] master 6705151: smb: fix wrong exported smb2 object due to h
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 May 2018 04:29:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67051511eda77d96fe58d7c1b883ccb4999b97ca
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6705151 by Peter Wu (peter@xxxxxxxxxxxxx):

    smb: fix wrong exported smb2 object due to hash collision
    
    While SMB1 FIDs are 16-bit, those used in SMB2 are a GUID of 128-bit
    which are compressed down to 32-bit using g_str_hash. To reduce
    collision probability which could associate wrong file data with an
    Exported Object entry, do not truncate this hash value to 16 bits.
    
    Bug: 14662
    Change-Id: I2a353eca96b0f5ed2157f3678280642151e2e4e7
    Reviewed-on: https://code.wireshark.org/review/27794
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  69e9dd2   ieee80211: Support raw 802.11 data frame dissectors
    adds  6705151   smb: fix wrong exported smb2 object due to hash collision


Summary of changes:
 epan/dissectors/packet-smb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)