Wireshark · Wireshark-commits: [Wireshark-commits] master 1d2b0d9: pem: validate the base64 lines

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d2b0d91e3d90062367052c4ac9753a6b78e0fcd
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1d2b0d9 by Роман Донченко (dpb@xxxxxxxxxxxxxx):

    pem: validate the base64 lines
    
    g_base64_decode_step will ignore all non-base64 characters, so make sure
    we catch such characters ourselves. Otherwise, if we encounter any
    non-conforming syntax, we'll parse it as base64 text, and consequently
    the BER dissector will receive nonsensical input.
    
    Change-Id: I38294141134626a3d98b5b12837d887492b18102
    Reviewed-on: https://code.wireshark.org/review/27653
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  d9c70ac   RANAP: optimize a bit the heuristic checks
    adds  1d2b0d9   pem: validate the base64 lines


Summary of changes:
 wiretap/pem.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)