Wireshark-commits: [Wireshark-commits] master cd49b7f: sccp: refactor XUDT/XUDTS dissection to redu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 May 2018 07:19:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd49b7f4fe379d62580956e7a647fde8d718b5e4
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cd49b7f by Peter Wu (peter@xxxxxxxxxxxxx):

    sccp: refactor XUDT/XUDTS dissection to reduce code duplication
    
    XUDT/XUDTS dissection had exactly the same code (minus a comment and
    some minor whitespace changes). To reduce code duplication, pull out the
    shared code. No functional change intended.
    
    Change-Id: I59dae50090808c927a592c8a237c9d564844876b
    Reviewed-on: https://code.wireshark.org/review/27675
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3f794bb   Make the two names for Unigraf DPA-400 captures the same.
    adds  cd49b7f   sccp: refactor XUDT/XUDTS dissection to reduce code duplication


Summary of changes:
 epan/dissectors/packet-sccp.c | 263 +++++++++++++++++-------------------------
 1 file changed, 106 insertions(+), 157 deletions(-)