Wireshark-commits: [Wireshark-commits] master ad80dd0: BOOTP: Disentangle BSDP naming from PacketCa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 May 2018 09:18:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad80dd083185a3c473131984dbe2705d3cf68ee5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ad80dd0 by Darius Davis (darius@xxxxxxxxxx):

    BOOTP: Disentangle BSDP naming from PacketCable.
    
    BSDP (Boot Server Discovery Protocol, layered upon BOOTP) is entirely Apple's
    creation, and has nothing to do with PacketCable as far as I can tell, so let's
    not label it as PacketCable.
    
    BSDPD is one possible name for a daemon that speaks the BSDP protocol, and it
    seems more reasonable to use the name of the protocol here, so let's replace
    "BSDPD" references with "BSDP", and use CLIENT and SERVER to better identify
    the Vendor Class ID prefixes.
    
    Change-Id: I6711022f16b37a2864482ba4eb544683865de274
    Reviewed-on: https://code.wireshark.org/review/27628
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8beb669   travis: add regression tests to pcap builds.
    adds  ad80dd0   BOOTP: Disentangle BSDP naming from PacketCable.


Summary of changes:
 epan/dissectors/packet-bootp.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)