Wireshark-commits: [Wireshark-commits] master-2.6 299832e: Windows: Make sure more native dialogs h
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 16 May 2018 16:15:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=299832e652562cf6a849fc7d01003adf586abd07
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

299832e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Windows: Make sure more native dialogs handle HiDPI.
    
    Add a WiresharkFileDialog class, which is a thin wrapper around a few
    QFileDialog functions that sets per-monitor v2 DPI awareness before
    showing native dialogs and resets the awareness context afterward.
    Use it where we call QFileDialog::getXXX.
    
    Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673
    Reviewed-on: https://code.wireshark.org/review/27568
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 62999cc6776e2b94e5a888ce77d6452a1020c660)
    Reviewed-on: https://code.wireshark.org/review/27580
    

Actions performed:

    from  ed29512   QT: Copy as printable
    adds  299832e   Windows: Make sure more native dialogs handle HiDPI.


Summary of changes:
 ui/qt/CMakeLists.txt                             |  2 +
 ui/qt/bluetooth_att_server_attributes_dialog.cpp |  5 +-
 ui/qt/bluetooth_device_dialog.cpp                |  4 +-
 ui/qt/bluetooth_devices_dialog.cpp               |  4 +-
 ui/qt/bluetooth_hci_summary_dialog.cpp           |  4 +-
 ui/qt/capture_interfaces_dialog.cpp              |  4 +-
 ui/qt/coloring_rules_dialog.cpp                  |  6 +--
 ui/qt/export_object_dialog.cpp                   |  6 +--
 ui/qt/extcap_argument_file.cpp                   |  5 +-
 ui/qt/firewall_rules_dialog.cpp                  |  4 +-
 ui/qt/follow_stream_dialog.cpp                   |  6 ++-
 ui/qt/iax2_analysis_dialog.cpp                   |  8 +--
 ui/qt/import_text_dialog.cpp                     |  4 +-
 ui/qt/io_graph_dialog.cpp                        |  4 +-
 ui/qt/lte_rlc_graph_dialog.cpp                   |  4 +-
 ui/qt/main_window_preferences_frame.cpp          |  4 +-
 ui/qt/main_window_slots.cpp                      |  5 +-
 ui/qt/manage_interfaces_dialog.cpp               |  1 -
 ui/qt/manager/wireshark_preference.cpp           |  8 +--
 ui/qt/models/path_chooser_delegate.cpp           |  4 +-
 ui/qt/module_preferences_scroll_area.cpp         |  8 +--
 ui/qt/rtp_analysis_dialog.cpp                    |  8 +--
 ui/qt/rtp_stream_dialog.cpp                      |  4 +-
 ui/qt/sctp_all_assocs_dialog.cpp                 |  1 -
 ui/qt/sctp_graph_dialog.cpp                      |  4 +-
 ui/qt/sequence_dialog.cpp                        |  4 +-
 ui/qt/show_packet_bytes_dialog.cpp               |  3 +-
 ui/qt/tap_parameter_dialog.cpp                   | 15 +++++-
 ui/qt/tcp_stream_dialog.cpp                      |  4 +-
 ui/qt/widgets/editor_file_dialog.cpp             |  5 +-
 ui/qt/widgets/wireshark_file_dialog.cpp          | 65 ++++++++++++++++++++++++
 ui/qt/widgets/wireshark_file_dialog.h            | 50 ++++++++++++++++++
 32 files changed, 199 insertions(+), 64 deletions(-)
 create mode 100644 ui/qt/widgets/wireshark_file_dialog.cpp
 create mode 100644 ui/qt/widgets/wireshark_file_dialog.h