Wireshark · Wireshark-commits: [Wireshark-commits] master 2af0e81: dissectors: fix uint to int wrong sign promotion.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2af0e81071c2bc58ba120351bfd17d3e16461c01
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2af0e81 by Dario Lombardo (lomato@xxxxxxxxx):

    dissectors: fix uint to int wrong sign promotion.
    
    The result of guint16 * guint16 can lead to a wrong sign promotion,
    when the result is assigned a uint64. Fixed by forcing the operands
    to be guint32.
    
    CIDs:
    1247713
    1111813
    1111812
    1111811
    1111810
    1111809
    1111808
    1111807
    
    Change-Id: Ibca08ee3766f6c79b933c3db7ccd1f8f906cb3fe
    Reviewed-on: https://code.wireshark.org/review/27441
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d7ea76d   x509: Add decoding of Userid "0.9.2342.19200300.100.1.1" "id-userid"
    adds  2af0e81   dissectors: fix uint to int wrong sign promotion.


Summary of changes:
 epan/dissectors/file-elf.c      | 6 +++---
 epan/dissectors/packet-s7comm.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)