Wireshark-commits: [Wireshark-commits] master 19c4589: proto: handle split bits covering more than
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 May 2018 08:14:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19c45892461da6f1767190c86c62dab02db8a2e3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

19c4589 by Peter Wu (peter@xxxxxxxxxxxxx):

    proto: handle split bits covering more than 32 bits
    
    proto_tree_add_split_bits_item_ret_val can handle bits from an arbitrary
    sized buffer, as long as it covers no more than 64 bits. If the
    octet-aligned mask covers up to 32 bits, then this mask is also shown.
    If this mask was larger than 64 bits, then undefined behavior could
    occur, so check for that.
    
    For larger masks, instead of "= GmPRS Terminal Type: Unknown (96)",
    display "7 bits = GmPRS Terminal Type: Unknown (96)" instead.
    
    Bug: 13613
    Change-Id: I111cf6a0705f999e42d83bfe57ac84f414946d0b
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1158
    Reviewed-on: https://code.wireshark.org/review/27517
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b10dbb8   ieee80211: Conform with IEEE802.11-2016 around VHT MCS Set in VHT Capabilities.
    adds  19c4589   proto: handle split bits covering more than 32 bits


Summary of changes:
 epan/proto.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)