Wireshark-commits: [Wireshark-commits] master 5507a34: Qt: fix memleaks in CompiledFilterOutput
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 18:41:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5507a34d1f0d1f96b3dc5283cca0619b05853f89
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5507a34 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix memleaks in CompiledFilterOutput
    
    QString already copies the memory, no need to strdup it. Simplify use of
    GString as well (str is NUL terminated). Found by Clang Static Analyzer.
    
    Change-Id: Ic3ba3daa9121736529e0bee2d41adc95a55a3feb
    Fixes: v1.99.0-rc1-253-gdf8c4bf264 ("Capture Interfaces Dialog:")
    Reviewed-on: https://code.wireshark.org/review/27344
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  064c09a   Qt: fix memleak of profile name on copying a profile
    adds  5507a34   Qt: fix memleaks in CompiledFilterOutput


Summary of changes:
 ui/qt/compiled_filter_output.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)