Wireshark-commits: [Wireshark-commits] master 612fb77: Qt: Update frame selected in several cases
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 06:21:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=612fb778f51b704745559345485f4ea44aa71aef
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

612fb77 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Update frame selected in several cases
    
    Ensure that frameSelected(0) is emitted when not having a proto tree
    field selected because of:
    
     1. No match when trying to restore selected field
     2. Search selects a packet with no field to select
     3. Current packet is deselected
    
    This will disable functionality which requires a selected field
    and updates the status bar according to selected field.
    
    Bug: 14658
    Change-Id: I158fae4f26c02f718cee0030ef9e38b597876381
    Reviewed-on: https://code.wireshark.org/review/27395
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  4513c66   You have to set tm_isdst before calling mktime().
    adds  612fb77   Qt: Update frame selected in several cases


Summary of changes:
 ui/qt/main_status_bar.cpp |  4 +++-
 ui/qt/packet_list.cpp     | 17 ++++++++++-------
 ui/qt/proto_tree.cpp      |  2 ++
 3 files changed, 15 insertions(+), 8 deletions(-)