Wireshark-commits: [Wireshark-commits] master 1ebbb09: plugin_if: fix small memory leak in ext_menu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 05 May 2018 05:57:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ebbb09c5bc7a73765e1fa84f6a29ad06731e3b6
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1ebbb09 by Peter Wu (peter@xxxxxxxxxxxxx):

    plugin_if: fix small memory leak in ext_menubar_add_separator
    
    No need to clone memory as ext_menubar_add_generic_entry g_strdups the
    label argument. Found by Clang Static Analyzer.
    
    Change-Id: I7ffe3d0cae0093410f2015e6beb8b8e97a871b2a
    Fixes: v1.99.6rc0-213-geeed4d1121 ("UI: Implementing menus for plugins")
    Reviewed-on: https://code.wireshark.org/review/27342
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  8569b80   pfcp: fix typo.
    adds  1ebbb09   plugin_if: fix small memory leak in ext_menubar_add_separator


Summary of changes:
 epan/plugin_if.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)