Wireshark-commits: [Wireshark-commits] master-2.2 32309cb: Pick the *first* usable file type as the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Apr 2018 19:11:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32309cbaa477d2b7d8f7036e9a1567e6254979e4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

32309cb by Guy Harris (guy@xxxxxxxxxxxx):

    Pick the *first* usable file type as the default, not the *last* one.
    
    In wtap_get_savable_file_types_subtypes(), in the search for a default
    file type to use, stop as soon as we've found a usable file type, don't
    keep searching.
    
    Bug: 14601
    Change-Id: Iff4ffe14f5ad07271c49a761e0856059353c1634
    Reviewed-on: https://code.wireshark.org/review/27193
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 1eb04d7ecb76c79cf681798b51aaa51aad938325)
    Reviewed-on: https://code.wireshark.org/review/27196
    

Actions performed:

    from  04204c9   cmake: remove warnings -Werror=old-style-definition
    adds  32309cb   Pick the *first* usable file type as the default, not the *last* one.


Summary of changes:
 wiretap/file_access.c | 1 +
 1 file changed, 1 insertion(+)