Wireshark-commits: [Wireshark-commits] master-2.6 f533639: Clean up EOF/short read/hard error handl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Apr 2018 21:21:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f533639be8b221df2f670c20b5c85b64d7914942
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

f533639 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up EOF/short read/hard error handling in heuristics.
    
    Do all the per-record processing in a libpcap_try_record() routine.  EOF
    on the header is OK, but a short read on the header *might* be due to
    the format being tested not being the format of the file rather than due
    to the file having been cut short.
    
    Change-Id: I5748ed550fa1079dc9c746fd93ee5c59187b80a1
    Reviewed-on: https://code.wireshark.org/review/27135
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f07fb6cdfc0904905627707b88450054e921f092)
    Reviewed-on: https://code.wireshark.org/review/27136
    

Actions performed:

    from  97be290   cmake: remove warnings -Werror=old-style-definition
    adds  f533639   Clean up EOF/short read/hard error handling in heuristics.


Summary of changes:
 wiretap/libpcap.c | 165 ++++++++++++++++++++++++------------------------------
 1 file changed, 72 insertions(+), 93 deletions(-)