Wireshark-commits: [Wireshark-commits] master e863ece: EtherCAT: Fix small bugs for mailbox type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Apr 2018 19:51:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e863ece7fcceeb8b18001824146d3c7dabe19924
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e863ece by Michalis Kapsalakis (kapsalis1989@xxxxxxxxx):

    EtherCAT: Fix small bugs for mailbox type
    
    This commit fixes the bug in the EtherCAT dissector for the FoE
    mailbox type. With this commit, the dissector displays the
    either foe_efw or foe_data in the ECAT_FOE_OPMODE_DATA,
    and not both of them as until now.
    
    Bug: 14613
    
    Change-Id: I09fc569f5adc5665c64653087c475f7f1d94639a
    Reviewed-on: https://code.wireshark.org/review/25336
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  826e0d5   Use tvb_new_subset_remaining() for a tvbuff that goes to end-of-packet.
    adds  e863ece   EtherCAT: Fix small bugs for mailbox type


Summary of changes:
 plugins/epan/ethercat/packet-ecatmb.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)