Wireshark-commits: [Wireshark-commits] master 328ccd4: zbee: Changed encoding for zcl command IDs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Apr 2018 10:08:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=328ccd448382a963cdc3a407583b1cef8698c2c8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

328ccd4 by Dana Sy (dana.hayden.sy@xxxxxxxxx):

    zbee: Changed encoding for zcl command IDs
    
    The command ID was passing the value of the cmd_id instead of the
    encoding for the proto_tree_add_item. This caused an issue with the
    color control cluster where it wasn't parsing the command ID properly.
    
    Change-Id: Iee42031146e37bb96182f765e79de47f6e4b5a04
    Reviewed-on: https://code.wireshark.org/review/27064
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  57fee05   wsutil: rename wsjsmn to wsjson.
    adds  328ccd4   zbee: Changed encoding for zcl command IDs


Summary of changes:
 epan/dissectors/packet-zbee-zcl-closures.c |  4 +--
 epan/dissectors/packet-zbee-zcl-general.c  | 48 +++++++++++++++---------------
 epan/dissectors/packet-zbee-zcl-ha.c       |  8 ++---
 epan/dissectors/packet-zbee-zcl-lighting.c |  2 +-
 epan/dissectors/packet-zbee-zcl-misc.c     |  8 ++---
 epan/dissectors/packet-zbee-zcl-sas.c      |  6 ++--
 6 files changed, 38 insertions(+), 38 deletions(-)