Wireshark-commits: [Wireshark-commits] master-2.6 15b05f6: Qt: Fix memory leak for CaptureEvent
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Apr 2018 14:08:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=15b05f6aeb2b693ae3ba1e6793bb3860a9b617ef
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

15b05f6 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix memory leak for CaptureEvent
    
    Make the argument to the events a non-memory object
    
    Cherry-Picked before merge, due to massive changes in master
    
    Change-Id: I46d8c24415aa2bc48b2a2d3b1fccffa6956d08b5
    Reviewed-on: https://code.wireshark.org/review/26979
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7c7de03   Qt: Fix segfault bug when analysing SCTP packets
    adds  15b05f6   Qt: Fix memory leak for CaptureEvent


Summary of changes:
 ui/qt/capture_file.cpp                | 62 ++++++++++++++++++++---------------
 ui/qt/capture_file.h                  |  8 +++--
 ui/qt/expert_info_dialog.cpp          | 10 +++---
 ui/qt/expert_info_dialog.h            |  2 +-
 ui/qt/export_object_action.cpp        |  8 ++---
 ui/qt/export_object_action.h          |  2 +-
 ui/qt/export_object_dialog.cpp        |  6 ++--
 ui/qt/export_object_dialog.h          |  2 +-
 ui/qt/follow_stream_dialog.cpp        |  6 ++--
 ui/qt/follow_stream_dialog.h          |  2 +-
 ui/qt/iax2_analysis_dialog.cpp        |  6 ++--
 ui/qt/iax2_analysis_dialog.h          |  2 +-
 ui/qt/io_graph_dialog.cpp             |  6 ++--
 ui/qt/io_graph_dialog.h               |  2 +-
 ui/qt/main_status_bar.cpp             | 14 ++++----
 ui/qt/main_status_bar.h               |  2 +-
 ui/qt/main_window.cpp                 | 12 +++----
 ui/qt/main_window.h                   |  2 +-
 ui/qt/main_window_slots.cpp           | 34 +++++++++----------
 ui/qt/multicast_statistics_dialog.cpp |  6 ++--
 ui/qt/multicast_statistics_dialog.h   |  2 +-
 ui/qt/traffic_table_dialog.cpp        |  6 ++--
 ui/qt/traffic_table_dialog.h          |  2 +-
 ui/qt/wireshark_application.cpp       |  8 ++---
 ui/qt/wireshark_application.h         |  2 +-
 ui/qt/wireshark_dialog.cpp            |  8 ++---
 ui/qt/wireshark_dialog.h              |  2 +-
 27 files changed, 117 insertions(+), 107 deletions(-)