Wireshark-commits: [Wireshark-commits] master-2.6 3ab69e0: x509ce: fix display of IPAddress when it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Apr 2018 08:23:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ab69e0c67f70eed49854dc19c73e9c8ddf4f181
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

3ab69e0 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    x509ce: fix display of IPAddress when it is an IPv6 Address
    
    According to RFC 5280 (Section 4.2.1.6. Subject Alternative Name), an
    iPAddress can be either four (IPv4) or sixteen octets (IPv6).
    
    Bug: 14603
    Change-Id: I6894f78c8e3f2a1b10940379397c87bbf981d4d6
    Reviewed-on: https://code.wireshark.org/review/26891
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 4fab4f678cd013c1b552be2cfd0b75425b4e17ee)
    Reviewed-on: https://code.wireshark.org/review/26939
    

Actions performed:

    from  91b653e   qt: capture file properties: add a splitter
    adds  3ab69e0   x509ce: fix display of IPAddress when it is an IPv6 Address


Summary of changes:
 .../asn1/x509ce/packet-x509ce-template.c           | 12 ++++---
 epan/dissectors/asn1/x509ce/x509ce.cnf             | 12 +++++--
 epan/dissectors/packet-x509ce.c                    | 40 ++++++++++++++--------
 3 files changed, 44 insertions(+), 20 deletions(-)