Wireshark-commits: [Wireshark-commits] master b3c51de: Rename the last argument to tvb_new_subset_l
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Apr 2018 17:53:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3c51deb2455c2ee07781d1808a02646f3395a35
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b3c51de by Guy Harris (guy@xxxxxxxxxxxx):

    Rename the last argument to tvb_new_subset_length().
    
    In tvb_new_subset_length_caplen(), the captured length argument is
    backing_length and the reported length argument is reported_length.  The
    length argument to tvb_new_subset_length() is a reported length, not a
    captured length, so call it reported_length, not backing_length.
    
    Change-Id: Ibfb30e15bdd885d3c0fd66e2b4b07c4a45327f14
    Reviewed-on: https://code.wireshark.org/review/26863
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b67a10c   "#if 0" out some currently-unused value_strings.
    adds  b3c51de   Rename the last argument to tvb_new_subset_length().


Summary of changes:
 epan/tvbuff.h        |  4 ++--
 epan/tvbuff_subset.c | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)