Wireshark-commits: [Wireshark-commits] master 9d87f60: If we're reading from a string, don't fclose
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 03 Apr 2018 01:04:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d87f607ee2ecefaff71f2ab3f2dc3d2dc185399
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9d87f60 by Guy Harris (guy@xxxxxxxxxxxx):

    If we're reading from a string, don't fclose yyin.
    
    yyin is initialized to stdin.  When we're reading from files, we set it
    so that it points to the FILE from which we're reading, but when we're
    reading from a string, we don't set it, leaving it to point to stdin.
    
    This means that, just as the "read from the input" routine has to be set
    differently when reading from a file or a string, the "close the current
    input" routine has to be set differently as well.
    
    Bug: 14577
    Change-Id: Ie05880775612867e9037ace2de0cd0a0dd2fabb5
    Reviewed-on: https://code.wireshark.org/review/26719
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  82bfb25   Fix a typo.
    adds  9d87f60   If we're reading from a string, don't fclose yyin.


Summary of changes:
 epan/diam_dict.l | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)