Wireshark-commits: [Wireshark-commits] master 8022238: tap: fix remaining potential memleaks with r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Mar 2018 04:51:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=802223829e9899638557c4cf13a5a643d96a0385
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8022238 by Peter Wu (peter@xxxxxxxxxxxxx):

    tap: fix remaining potential memleaks with register_tap_listener
    
    Additionally, add an attribute to the tap function to prevent future
    callers from leaking this memory.
    
    Change-Id: Ief6af2bbc74d19153628f09d7b273e85cb2284ab
    Reviewed-on: https://code.wireshark.org/review/26642
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3b042a7   There's no entity "Verizon"; there's "VerizonWireless".
    adds  8022238   tap: fix remaining potential memleaks with register_tap_listener


Summary of changes:
 epan/tap.h                  |  2 +-
 ui/gtk/flow_graph.c         | 10 +++++++++-
 ui/qt/rtp_player_dialog.cpp | 10 +++++++++-
 ui/qt/sequence_dialog.cpp   |  8 +++++++-
 ui/qt/wireless_timeline.cpp | 10 ++++++++--
 5 files changed, 34 insertions(+), 6 deletions(-)