Wireshark-commits: [Wireshark-commits] master 841c275: rpcrdma: make sure that heuristic checks don
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Mar 2018 20:21:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=841c27516c7cd20f7fbea3b610b84dd214bc41a7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

841c275 by Martin Kaiser (wireshark@xxxxxxxxx):

    rpcrdma: make sure that heuristic checks don't throw an exception
    
    We should not be throwing an exception while checking if the packet
    really contains our protocol. Add a length check to make sure that the
    initial tvb_get_ntohl() call will not fail.
    
    Read the message type after the heuristic check.
    
    Change-Id: I397732dbec20bcd0ab5356e8c3500fd0cb6e1434
    Reviewed-on: https://code.wireshark.org/review/26634
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c8adf25   Docs: Fix some cross references.
    adds  841c275   rpcrdma: make sure that heuristic checks don't throw an exception


Summary of changes:
 epan/dissectors/packet-rpcrdma.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)