Wireshark-commits: [Wireshark-commits] master-2.4 889d670: TRANSUM: Fix DNS-related bug and improve
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=889d67071dcd0a853b30a3f854a72238241c7327
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark
Commits:
889d670 by Paul Offord (paul.offord@xxxxxxxxxxxx):
TRANSUM: Fix DNS-related bug and improve performance
These changes significantly improve the speed and accuracy of TRANSUM.
I have removed the concept of rrpd status as it wasn't being used in any
significant way and created unnecessary code.
The find_latest_rrpd(...) function was becoming very complex which made it
difficult to optimise performance for certain protocols. To overcome
this, I have introduced an equivalent function for each protocol e.g.
find_latest_rrpd_smb2(...). each of these new functions has a loop that
steps through the rrpd_list. I could have placed this loop one level up
in the nested call and so had one loop in the code that calls the new
function. However, I have found that this area is the prime cause of
delays in TRANSUM execution and so I want to avoid calling these new
functions with each step through the rrpd_list.
Finally, I have added code to improve the handling of retransmissions.
Bug: 14210
Change-Id: I038097f22a45ee74173aad1ae5732347f769b9bd
Reviewed-on: https://code.wireshark.org/review/24506
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
(cherry picked from commit 36372a2465c94784240ba8c38b53b4eedb234868)
Reviewed-on: https://code.wireshark.org/review/26628
Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d5e5d76 [Automatic update for 2018-03-25]
adds 889d670 TRANSUM: Fix DNS-related bug and improve performance
Summary of changes:
plugins/transum/decoders.c | 37 ++-
plugins/transum/packet-transum.c | 694 +++++++++++++++++++++++----------------
plugins/transum/packet-transum.h | 22 +-
plugins/transum/preferences.h | 1 +
4 files changed, 446 insertions(+), 308 deletions(-)
