Wireshark-commits: [Wireshark-commits] master 494508f: Clean up REPORT_DISSECTOR_BUG().
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=494508f2d02d8380c4060354fa06de6a3de417f4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
494508f by Guy Harris (guy@xxxxxxxxxxxx):
Clean up REPORT_DISSECTOR_BUG().
Have it take a format and argument list as arguments, and have the
formatting done inside the reporting code. That way, we're not relying
on any particular wmem scope working.
If WIRESHARK_ABORT_ON_DISSECTOR_BUG is set, try to add the message to
the crash information (currently only supported in macOS), and print it
to the standard error, before crashing. We won't necessarily have a
usable crash dump to analyze, so we can't rely on that to find the cause
of the crash.
Ping-Bug: 14490
Change-Id: I2b39169c45c84f2ada31efa1d413bd28c140f8f4
Reviewed-on: https://code.wireshark.org/review/26643
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 6a75c59 Fix whitespace.
adds 494508f Clean up REPORT_DISSECTOR_BUG().
Summary of changes:
epan/dissectors/asn1/acse/packet-acse-template.c | 3 +-
epan/dissectors/packet-acse.c | 7 +-
epan/dissectors/packet-isakmp.c | 65 ++++-----
epan/dissectors/packet-lustre.c | 9 +-
epan/except.c | 13 +-
epan/except.h | 2 +
epan/exceptions.h | 4 +
epan/proto.c | 164 ++++++++++++-----------
epan/proto.h | 67 ++++-----
wsutil/crash_info.c | 17 ++-
wsutil/crash_info.h | 2 +
11 files changed, 173 insertions(+), 180 deletions(-)
