Wireshark-commits: [Wireshark-commits] master-2.4 f13ff5d: In some dialogs, have *no* auto-default
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Mar 2018 02:23:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f13ff5dbd8d9e9a8b78eed1cb90ea12cf0bd0466
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

f13ff5d by Guy Harris (guy@xxxxxxxxxxxx):

    In some dialogs, have *no* auto-default buttons on macOS.
    
    In macOS dialogs, there's a default button, which is the button that
    Enter/Return activates, and that Enter/Return *always* activates,
    *regardless* of what button has the input focus.  To activate the button
    that has the input focus, you use the space bar.
    
    To implement that, we need to disable auto-default on all buttons,
    including the Cancel button.
    
    Put in a comment explaining all this.
    
    We may want to do this in all alert boxes, and possibly all dialogs with
    buttons.
    
    Change-Id: I214dd2870a9720ea705d8db39adc5b6af2003fb1
    Reviewed-on: https://code.wireshark.org/review/26629
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b577bff1ae1187471e0df2e4477b75ff548f1510)
    Reviewed-on: https://code.wireshark.org/review/26630
    

Actions performed:

    from  9d328c8   Hand off to the PPC-in-HDLC-like-framing dissector.
    adds  f13ff5d   In some dialogs, have *no* auto-default buttons on macOS.


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 26 +++++++++++++++++++++++++-
 ui/qt/main_window.cpp         | 29 ++++++++++++++++++++++++++++-
 2 files changed, 53 insertions(+), 2 deletions(-)