Wireshark-commits: [Wireshark-commits] master 18cd454: S1AP: fix filtering on cell-ID
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Mar 2018 14:37:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18cd454da9e99c4d85d6afbe9c3b831e65d559b6
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

18cd454 by Pavel Strnad (pavel_strnad@xxxxxxxxxxx):

    S1AP: fix filtering on cell-ID
    
    Filter does not work due to same shared short name for cell-id being used for two different asn.1 defintions
      cell-ID OCTET STRING,
      cell-ID CellIdentity,
    
    Change-Id: I5921bc82d46f38d43f9083e41d3a0558821042eb
    Reviewed-on: https://code.wireshark.org/review/26545
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Pavel Strnad <pavel_strnad@xxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  4d3c8bc   MAC-NR: unify BSR filters
    adds  18cd454   S1AP: fix filtering on cell-ID


Summary of changes:
 epan/dissectors/asn1/s1ap/s1ap.cnf | 11 +++++++++++
 epan/dissectors/packet-s1ap.c      | 16 ++++++++++++----
 2 files changed, 23 insertions(+), 4 deletions(-)