Wireshark-commits: [Wireshark-commits] master-2.4 c8e2374: nordic_ble: Fix delta time start-to-star
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Mar 2018 09:46:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8e2374d1b2c16427bed6bf4bdfd9d810166cce2
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

c8e2374 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    nordic_ble: Fix delta time start-to-start calculation
    
    The on-air time for a packet was calculated wrong because it was
    using the wrong number of on-air bytes.  This has been corrected.
    
    Calculating delta time start-to-start for BLE 4.2 requires support
    for on-air packet size up to 255 bytes (LE Data Length Extensions).
    For this the payload length size in the header has changed to two
    bytes.
    
    Calculating delta time start-to-start for BLE 5.0 needs physical
    layer data rate (LE 1M PHY or LE 2M PHY). For this the flags was
    extended with PHY values.
    
    Removed superfluous min and max length checks.
    
    Change-Id: I40bef14f0c19ee77a402efc76e5d01826e63e603
    Reviewed-on: https://code.wireshark.org/review/26457
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit a2cbec743e9c25154281413ea6062ecf81a8a5ea)
    Reviewed-on: https://code.wireshark.org/review/26470
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  31dbf85   GSM BSSMAP: fix a typo in in speech version range_string
    adds  c8e2374   nordic_ble: Fix delta time start-to-start calculation


Summary of changes:
 epan/dissectors/packet-nordic_ble.c | 279 +++++++++++++++++++++++++-----------
 1 file changed, 199 insertions(+), 80 deletions(-)