Wireshark-commits: [Wireshark-commits] master ba179a7: eth: fix null pointer dereference when calle
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Mar 2018 04:44:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba179a7ef7e660d788cbaade65982ffc7249b91f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba179a7 by Peter Wu (peter@xxxxxxxxxxxxx):

    eth: fix null pointer dereference when called from Lua
    
    At the moment, Lua dissectors always pass a NULL data parameter, so
    dissectors like eth should gracefully handle that.
    
    Bug: 14293
    Change-Id: Ida4d0530a9c417db5960475274315d4acc3704a8
    Fixes: v2.1.0rc0-1575-g8ec153f938 ("Have the "maybe an FCS" version of the Ethernet dissector take a data argument.")
    Reviewed-on: https://code.wireshark.org/review/26431
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7e842fa   F5ETHTRAILER: Initial cleanup from submission
    adds  ba179a7   eth: fix null pointer dereference when called from Lua


Summary of changes:
 epan/dissectors/packet-eth.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)