Wireshark-commits: [Wireshark-commits] master 1867143: dcm: Fixed crash in dissector, and other bug
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 06 Mar 2018 15:43:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=186714314d546c2155cb0942724e8bafb9bd879f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1867143 by david-aggeler (david_aggeler@xxxxxxxxx):

    dcm: Fixed crash in dissector, and other bugs Some tag descriptions which are added to the parent item (32 tags). If one of those was empty a crash occurred. Mainly the RTPlan modality was affected.
    
    Fixed length decoding for OD, OL, UC, UR Fixed hf_dcm_assoc_item_type to be interpreted as 1 byte
    Fixed pdu_type to be interpreted as 1 byte
    Fixed decoding of AT type, where value length was wrongly reported in capture as 2 (instead of n*4)
    Removed tailing white spaces
    Please merge to 2.4 once ok.
    
    Bug: 14415
    Change-Id: I7857ef107e7e599c7dd9f8d069daa5b3bfb4122f
    Reviewed-on: https://code.wireshark.org/review/26268
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0632770   Use the generic function decode_zcl_time_in_100ms instead of the local zcl_fmt_time_tenths.
    adds  1867143   dcm: Fixed crash in dissector, and other bugs Some tag descriptions which are added to the parent item (32 tags). If one of those was empty a crash occurred. Mainly the RTPlan modality was affected.


Summary of changes:
 epan/dissectors/packet-dcm.c | 395 +++++++++++++++++++++++++------------------
 1 file changed, 226 insertions(+), 169 deletions(-)