Wireshark-commits: [Wireshark-commits] master-2.2 66bc372: NBAP: avoid linking a DCH-ID to itself
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 05 Mar 2018 18:12:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66bc372716e04d6a8afdf6712583c9b5d11fee55
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

66bc372 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NBAP: avoid linking a DCH-ID to itself
    
    Otherwise it can create an infinite loop, leading to a buffer overflow.
    Also add explicit cheks on the buffer usage and set its maximum size to
    128 instead of 32 per ASN.1 description.
    
    Bug: 14471
    Change-Id: I18d26369cf3d1cf2a32c86a972c78ea9f6f7a503
    Reviewed-on: https://code.wireshark.org/review/26264
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 1c9adc63c2c2892a3f069777dfb8c66f79b9ba38)
    Conflicts:
    	epan/dissectors/asn1/nbap/nbap.cnf
    	epan/dissectors/packet-nbap.c
    	epan/dissectors/packet-umts_fp.h
    Reviewed-on: https://code.wireshark.org/review/26267
    

Actions performed:

    from  14d6f71   IEEE 802.15.4: always allocate protocol data if not present
    adds  66bc372   NBAP: avoid linking a DCH-ID to itself


Summary of changes:
 epan/dissectors/asn1/nbap/nbap.cnf | 8 ++++----
 epan/dissectors/packet-nbap.c      | 8 ++++----
 epan/dissectors/packet-umts_fp.h   | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)