Wireshark-commits: [Wireshark-commits] master cde7cc5: NBAP: avoid linking a DCH-ID to itself
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 05 Mar 2018 01:55:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cde7cc54a33659222ee8ee05d346918da45e4c82
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cde7cc5 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NBAP: avoid linking a DCH-ID to itself
    
    Otherwise it can create an infinite loop, leading to a buffer overflow.
    Also add explicit cheks on the buffer usage and set its maximum size to
    128 instead of 32 per ASN.1 description.
    
    Bug: 14471
    Change-Id: I805f4ce09347bc35143b010b4a558a0d090c0159
    Reviewed-on: https://code.wireshark.org/review/26259
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  df83de9   wisun: dissect Wi-SUN Netricity IEs
    adds  cde7cc5   NBAP: avoid linking a DCH-ID to itself


Summary of changes:
 epan/dissectors/asn1/nbap/nbap.cnf | 8 ++++----
 epan/dissectors/packet-nbap.c      | 8 ++++----
 epan/dissectors/packet-umts_fp.h   | 6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)