Wireshark-commits: [Wireshark-commits] master b70eb18: mmse: remove a ton of if (tree) checks
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Mar 2018 07:47:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b70eb189bb906d0b03ca95219a4c9c82eee43f97
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b70eb18 by Martin Kaiser (wireshark@xxxxxxxxx):

    mmse: remove a ton of if (tree) checks
    
    Keep the "global" check where the entire processing was under if (tree).
    Move this check in front of the while loop and exit if we have no tree.
    
    Remove the subsequent (duplicate) checks for indivial
    proto_tre_add_...() calls.
    
    Change-Id: I6b978b438b9f1c84c8927ae4eb9c53a8eaadb4ef
    Reviewed-on: https://code.wireshark.org/review/26246
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4630b4f   clean up tvb_get_guintvar() a bit more
    adds  b70eb18   mmse: remove a ton of if (tree) checks


Summary of changes:
 epan/dissectors/packet-mmse.c | 1005 +++++++++++++++++++----------------------
 1 file changed, 470 insertions(+), 535 deletions(-)