Wireshark-commits: [Wireshark-commits] master 1a09879: Generalize our process spawning code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Mar 2018 05:22:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a0987904fa571dc5abce03726e4ca3e17793574
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a09879 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Generalize our process spawning code.
    
    Move the contents of extcap_spawn to ws_pipe. Rename various extcap_*
    prefixes to ws_pipe_*. Open stdin when we spawn processes.
    
    Change-Id: I9286295443ee955bb6328b0ed6f945ee0bb2a798
    Reviewed-on: https://code.wireshark.org/review/26216
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bf4c2fd   Windows: Remove cruft for unsupported versons
    adds  1a09879   Generalize our process spawning code.


Summary of changes:
 CMakeLists.txt   |   1 -
 Makefile.am      |   4 +-
 capture_opts.c   |  11 +-
 capture_opts.h   |   8 +-
 extcap.c         |  71 +++++------
 extcap_spawn.c   | 381 -------------------------------------------------------
 extcap_spawn.h   |  54 --------
 wsutil/ws_pipe.c | 352 ++++++++++++++++++++++++++++++++++++++++++++++++++
 wsutil/ws_pipe.h |  26 ++++
 9 files changed, 420 insertions(+), 488 deletions(-)
 delete mode 100644 extcap_spawn.c
 delete mode 100644 extcap_spawn.h