Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 23c0a41: adb: fix buffer overflow while processing message payload

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23c0a41442e8e926b4d1f0aa8a887a83261e64ee
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

23c0a41 by Peter Wu (peter@xxxxxxxxxxxxx):

    adb: fix buffer overflow while processing message payload
    
    Fix a heap buffer overflow (write) when the message header length is
    smaller than the actual message payload length. Add expert info to
    detect this since it can also occur when the header is wrongly matched
    with a data fragment (this dissector issue is not fixed here).
    
    Bug: 14460
    Change-Id: I12f411a5189809a0931dfcdb2797997d5e19efc1
    Reviewed-on: https://code.wireshark.org/review/26104
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1653ea5fcedf369452c0cf41e09e57666525615c)
    Reviewed-on: https://code.wireshark.org/review/26172
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4ed90d4   6lowpan: Use correct offset for "UDP header compression" header
    adds  23c0a41   adb: fix buffer overflow while processing message payload


Summary of changes:
 epan/dissectors/packet-adb.c | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)