Wireshark-commits: [Wireshark-commits] master d4ef22d: Make sure CAPACITY() doesn't shift the 1 out
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2018 02:52:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d4ef22db8f21f7ed5ebf16bfcf335e32102bfe8d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d4ef22d by Guy Harris (guy@xxxxxxxxxxxx):

    Make sure CAPACITY() doesn't shift the 1 out of range.
    
    Make the 1 we shift left the size of a size_t, so it'll only go out of
    range if the result couldn't possibly fit in a size_t.  (That should
    also make the object of the shift unsigned, which may squelch some other
    complaints.)
    
    Not that the map is *likely* to be bigger than 4GB, but it should
    squelch some complaints from Visual Studio Code Analysis.
    
    Change-Id: I489bfe6b1d9d4329c267936d9106dbba4388c492
    Reviewed-on: https://code.wireshark.org/review/26163
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ac69a67   ieee80211: Fix the handling of PPE Thresholds for 802.11ax.
    adds  d4ef22d   Make sure CAPACITY() doesn't shift the 1 out of range.


Summary of changes:
 epan/wmem/wmem_map.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)