Wireshark-commits: [Wireshark-commits] master ba0f4b9: adb: fix Malformed packet while parsing CONN
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Feb 2018 09:10:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba0f4b9d9f954c985cd260feeae4560b5f54668a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba0f4b9 by Peter Wu (peter@xxxxxxxxxxxxx):

    adb: fix Malformed packet while parsing CONNECT command
    
    Previous adb versions included a NULL terminator in the banner, but this
    is not required by the specification[1] and in newer versions there is
    no such terminator. This patch fixes issue 1 of bug 14460.
    
     [1]: https://android.googlesource.com/platform/system/core/+/android-8.1.0_r7/adb/protocol.txt#56
    
    Change-Id: I0a3ad1499d68d38c430dd386854ddba0ce755538
    Ping-Bug: 14460
    Reviewed-on: https://code.wireshark.org/review/26097
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  61d0336   Qt/USB: Allow USB src/dst addresses to be selected for columns
    adds  ba0f4b9   adb: fix Malformed packet while parsing CONNECT command


Summary of changes:
 epan/dissectors/packet-adb.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)