Wireshark-commits: [Wireshark-commits] master c0b2d82: Suppress some warnings caused by a Berkeley
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Feb 2018 13:25:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0b2d82fc4462370f7a280c14c61e57bc5a7f239
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c0b2d82 by Guy Harris (guy@xxxxxxxxxxxx):

    Suppress some warnings caused by a Berkeley YACC bug/misfeature.
    
    Berkeley YACC generates a global declaration of yylval, or the
    appropriately prefixed version of yylval, in the .h file, *even though
    it's been told to generate a pure parser, meaning it doesn't have any
    global variables*.  Bison doesn't do this.
    
    That causes a warning due to the local declaration in the parser
    shadowing the global declaration.
    
    So, if this is Berkeley YACC, and we have _Pragma, and have pragmas to
    suppress diagnostics, we use it to turn off -Wshadow warnings.
    
    Change-Id: Ia3fecd99fa18ca9b85f6b25f53ed36c60730fad9
    Reviewed-on: https://code.wireshark.org/review/26080
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f07d295   TLS1.3: Add support of draft-24
    adds  c0b2d82   Suppress some warnings caused by a Berkeley YACC bug/misfeature.


Summary of changes:
 wiretap/ascend.y  |  6 ++++++
 ws_diag_control.h | 29 +++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)