Wireshark-commits: [Wireshark-commits] master ba58d62: Fix endianness.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 18:25:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba58d62cd13b2dfe39d62022cc066687019685de
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba58d62 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix endianness.
    
    Make the 1-byte fields little-endian (it doesn't matter, but it's more
    consistent that way), and make the transmission attenuation fields
    little-endian (where it *does* matter - making them big-endian was
    probably a copy-and-pasteo).
    
    Note that the OUI field being "big-endian" is correct, however.
    (Radiotap specifies it as an array of 3 octets containing an OUI, and we
    display OUIs as big-endian 24-bit quantities.)
    
    Change-Id: I42d19f7ec0d066ce89dbef78d11dff900c0a6b60
    Reviewed-on: https://code.wireshark.org/review/25998
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2112490   nettrace: remove wrong frees (found by clang).
    adds  ba58d62   Fix endianness.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 36 +++++++++++++++++------------
 1 file changed, 21 insertions(+), 15 deletions(-)