Wireshark-commits: [Wireshark-commits] master 2054242: Qt: Improve our capture filter completions.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 05:02:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=205424287b0ff732ad555ddc2026f1422633cb12
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2054242 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Improve our capture filter completions.
    
    Use libpcap's pcap-filter.manmisc to create our capture filter
    completion list instead of scanner.l.
    
    Bug: 14430
    Change-Id: I11f6eb5679dc93561dce62f28149e103ac9b4a2b
    Reviewed-on: https://code.wireshark.org/review/25971
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5d45b69   WCCP: Make sure our offset increases.
    adds  2054242   Qt: Improve our capture filter completions.


Summary of changes:
 ui/qt/widgets/capture_filter_edit.cpp | 87 +++++++++++++++++++++++++++--------
 1 file changed, 69 insertions(+), 18 deletions(-)