Wireshark-commits: [Wireshark-commits] master 22dc113: Don't start command-line taps until we've op
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Feb 2018 20:40:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22dc113852fb512f81c68ae1eb6914f27f616f12
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

22dc113 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't start command-line taps until we've opened a file or started capturing.
    
    We shouldn't do so until we have something on which to compute
    statistics and until we're in file scope, as the taps may use
    file-scoped memory, given that statistics pertain to a file.
    
    Change-Id: Ifb568480a3cbbd4dc891015b3bb42da1511ca514
    Reviewed-on: https://code.wireshark.org/review/25887
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d9d6106   ASN.1: update auto generated dissectors
    adds  22dc113   Don't start command-line taps until we've opened a file or started capturing.


Summary of changes:
 tshark.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)