Wireshark-commits: [Wireshark-commits] master d0b9db8: Qt: Add separators between filter expression
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Feb 2018 08:26:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0b9db8cd8f9290173860f8cc52e89834b253331
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d0b9db8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add separators between filter expression buttons.
    
    I've noticed at SharkFest and other places that people sometimes put
    square brackets around their filter expression names so that it's easier
    to distinguish one button from another.
    
    Add separators between buttons so that this shouldn't be necessary.
    
    Change-Id: I3b1ca42f6417d2045781fc14d594faba4fd00fd5
    Reviewed-on: https://code.wireshark.org/review/25820
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  459bd46   Don't have CLEAN_FILES variables for the "clean" source files.
    adds  d0b9db8   Qt: Add separators between filter expression buttons.


Summary of changes:
 ui/qt/main_window.cpp       | 29 +++++++++++++++++++++--------
 ui/qt/main_window_slots.cpp |  3 +++
 2 files changed, 24 insertions(+), 8 deletions(-)