Wireshark-commits: [Wireshark-commits] master-2.4 f82c54a: SCCP: Use int datatype for offset to pre
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Feb 2018 13:34:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f82c54a4532b7dba5cb498195f39af32569b3149
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

f82c54a by Michael Mann (mmann78@xxxxxxxxxxxx):

    SCCP: Use int datatype for offset to prevent infinite loops
    
    Fields are 16-bit values and large 16-bit values can be incorrectly
    treated as negative, causing infinite loops in offset calculations.
    
    Bug: 14413
    Change-Id: I44334c3e9ced0734f4e1a70720859c0abf4a05c8
    Reviewed-on: https://code.wireshark.org/review/25743
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 620647a3e01d65fef985093cefb9352e21603261)
    Reviewed-on: https://code.wireshark.org/review/25750
    

Actions performed:

    from  2e83207   RPC Netlogon: do not leak memory each time a hash is generated
    adds  f82c54a   SCCP: Use int datatype for offset to prevent infinite loops


Summary of changes:
 epan/dissectors/packet-sccp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)