Wireshark-commits: [Wireshark-commits] master ae91f43: Extract HKDF-Expand from TLS 1.3 dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Feb 2018 08:37:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae91f43155662d857b6e4e07a67c244f921e0a8b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae91f43 by Peter Wu (peter@xxxxxxxxxxxxx):

    Extract HKDF-Expand from TLS 1.3 dissector
    
    HKDF (RFC 5869) is a standard construct used in TLS 1.3, QUIC and
    OSCORE, generalize it for use outside the TLS dissector.
    
    Since none of the users need the "context" (formerly "hash_value")
    field, remove the parameter.
    
    Change-Id: Id952de8cb3000f6f6eda844d17c78bbd3906a84d
    Reviewed-on: https://code.wireshark.org/review/25723
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d2016c6   RPC Netlogon: do not leak memory each time a hash is generated
    adds  ae91f43   Extract HKDF-Expand from TLS 1.3 dissector


Summary of changes:
 epan/dissectors/packet-quic.c      |  12 +++--
 epan/dissectors/packet-ssl-utils.c | 101 ++++++++++++++++++-------------------
 epan/dissectors/packet-ssl-utils.h |   6 +--
 wsutil/wsgcrypt.c                  |  38 ++++++++++++++
 wsutil/wsgcrypt.h                  |  17 +++++++
 5 files changed, 114 insertions(+), 60 deletions(-)