Wireshark-commits: [Wireshark-commits] master 0b649a0: Separately count all records and data record
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Feb 2018 03:44:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b649a09100813151555308d6ccdbd18ec43accd
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0b649a0 by Guy Harris (guy@xxxxxxxxxxxx):

    Separately count all records and data records.
    
    A file might contain only metadata records, which exist only to provide
    information needed to interpret data records; no point in showing them
    in record counts.
    
    Put the counts into the structure that we fill in, and rename the
    structure and the routine to reflect that it determines statistics other
    than just times.
    
    Speak of data records rather than packets; the file might be full of
    Sysdig event records but not have any packets in it, for example.
    
    Change-Id: I8553181dca4129736bdae2c0cbba92becc28d6ef
    Reviewed-on: https://code.wireshark.org/review/25722
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9797f34   Move the merge_action_e enum to the Win32 file dialog source file.
    adds  0b649a0   Separately count all records and data records.


Summary of changes:
 ui/file_dialog.c              | 61 ++++++++++++++++++++++++++-----------------
 ui/file_dialog.h              | 20 +++++++-------
 ui/gtk/capture_file_dlg.c     | 57 ++++++++++++++++++++++++----------------
 ui/qt/capture_file_dialog.cpp | 47 ++++++++++++++++++++-------------
 ui/win32/file_dlg_win32.c     | 49 +++++++++++++++++++++-------------
 5 files changed, 142 insertions(+), 92 deletions(-)