Wireshark-commits: [Wireshark-commits] master-2.2 b56f598: FCP: Add NULL check to prevent crash.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Feb 2018 05:18:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b56f598f1bc04f5d00f13b38c713763928cedb7c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b56f598 by Michael Mann (mmann78@xxxxxxxxxxxx):

    FCP: Add NULL check to prevent crash.
    
    Fragmented FCP may not be called on the first pass, so add a NULL
    check for proto_data that may not be there.
    
    Bug: 14374
    Change-Id: Icbbee8f0eb3a33655323283dbb5a01c350d784dc
    Reviewed-on: https://code.wireshark.org/review/25649
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit f4f44caa3525bb382f903f3abda387ccc0cad806)
    Reviewed-on: https://code.wireshark.org/review/25654
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c784d55   Thrift: stop dissection when encountering an unknown/unexpected type
    adds  b56f598   FCP: Add NULL check to prevent crash.


Summary of changes:
 epan/dissectors/packet-fcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)