Wireshark-commits: [Wireshark-commits] master cb1a652: Get rid of the pkt_encap field in struct pac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 06 Feb 2018 20:35:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb1a6528f968c3cd97660217abc1a6725ff5ba92
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cb1a652 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of the pkt_encap field in struct packet_info.
    
    pinfo->pkt_encap is jsut a copy of pinfo->phdr->pkt_encap; no need for
    the copy.
    
    Expand a comment while we're at it.
    
    Change-Id: I5fcfe694ecba42507f1d629d01440da0a0989501
    Reviewed-on: https://code.wireshark.org/review/25643
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6db88da   Change the way we infer the type of the physical address.
    adds  cb1a652   Get rid of the pkt_encap field in struct packet_info.


Summary of changes:
 epan/dissectors/file-file.c    |  6 +++---
 epan/dissectors/packet-frame.c | 10 +++++-----
 epan/dissectors/packet-nettl.c |  2 +-
 epan/dissectors/packet-snort.c | 12 +++++++++---
 epan/packet.c                  |  1 -
 epan/packet_info.h             |  1 -
 epan/wslua/wslua_dumper.c      |  4 ++--
 7 files changed, 20 insertions(+), 16 deletions(-)