Wireshark · Wireshark-commits: [Wireshark-commits] master 8556f65: pcapng_read_block() should just return a Boolean.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8556f65e0740af647482a6fca86371bbc498b68e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8556f65 by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng_read_block() should just return a Boolean.
    
    It either returns "OK" or "fail", so we might as well make it a Boolean.
    
    While we're at it, in pcapng_open(), handle EOF/short read and "invalid
    file" errors when trying to read the first block differently; for the
    first of those, we don't need to free *err_info, and this may be a bit
    safer in case *err_info didn't happen to be set to NULL somewhere along
    the line.
    
    Change-Id: If8135624e3efb7838dceeb28e30e5c8c4b064786
    Reviewed-on: https://code.wireshark.org/review/25608
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f53750a   pcapng_read_section_header_block() should just return a Boolean.
    adds  8556f65   pcapng_read_block() should just return a Boolean.


Summary of changes:
 wiretap/pcapng.c | 77 +++++++++++++++++++++++++++-----------------------------
 1 file changed, 37 insertions(+), 40 deletions(-)