Wireshark-commits: [Wireshark-commits] master 121abba: Have individual plugin CMakeLists.txt files
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Feb 2018 02:04:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=121abba1a237fba2c9a9377ced3ca7a47b5eef25
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

121abba by Guy Harris (guy@xxxxxxxxxxxx):

    Have individual plugin CMakeLists.txt files add library dependencies.
    
    This removes any knowledge of plugin types from
    cmake/modules/WiresharkPlugin.cmake, so that it doesn't have to be
    changed if we add a new plugin type.  Revert to the second argument to
    add_plugin_library() and install_plugin() being the subfolder.
    
    Change-Id: I668ab90b28c73a8b12ca8e3e906b8de2f9395ca5
    Reviewed-on: https://code.wireshark.org/review/25585
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ebef0b0   New symbols.
    adds  121abba   Have individual plugin CMakeLists.txt files add library dependencies.


Summary of changes:
 cmake/modules/WiresharkPlugin.cmake      | 23 ++---------------------
 plugins/epan/docsis/CMakeLists.txt       |  2 ++
 plugins/epan/ethercat/CMakeLists.txt     |  2 ++
 plugins/epan/gryphon/CMakeLists.txt      |  2 ++
 plugins/epan/irda/CMakeLists.txt         |  2 ++
 plugins/epan/mate/CMakeLists.txt         |  2 ++
 plugins/epan/opcua/CMakeLists.txt        |  2 ++
 plugins/epan/pluginifdemo/CMakeLists.txt |  2 +-
 plugins/epan/profinet/CMakeLists.txt     |  2 ++
 plugins/epan/stats_tree/CMakeLists.txt   |  2 ++
 plugins/epan/transum/CMakeLists.txt      |  2 ++
 plugins/epan/unistim/CMakeLists.txt      |  2 ++
 plugins/epan/wimax/CMakeLists.txt        |  2 ++
 plugins/epan/wimaxasncp/CMakeLists.txt   |  2 ++
 plugins/epan/wimaxmacphy/CMakeLists.txt  |  2 ++
 plugins/wiretap/usbdump/CMakeLists.txt   |  2 ++
 16 files changed, 31 insertions(+), 22 deletions(-)